Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 20, 2026

No description provided.

@AdamGS AdamGS added the experiment Tests an idea label Jan 20, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 29.73%

Comparing adamg/make-windows-really-unsafe (64d5fc2) with develop (590119c)

Summary

⚡ 24 improved benchmarks
❌ 9 regressed benchmarks
✅ 1221 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decompress_bitpacking_early_filter[i16, 0.03] 241.5 µs 199 µs +21.34%
Simulation decompress_bitpacking_early_filter[i16, 0.05] 275.7 µs 233 µs +18.28%
Simulation decompress_bitpacking_early_filter[i16, 0.04] 258.2 µs 215.6 µs +19.75%
Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 226.8 µs 311.2 µs -27.13%
Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 381.3 µs 465.8 µs -18.14%
Simulation canonical_into_nullable[(10000, 10, 0.0)] 526.3 µs 454.6 µs +15.77%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.3 ms 5.1 ms -15.93%
Simulation into_canonical_nullable[(10000, 10, 0.0)] 448.2 µs 529.7 µs -15.4%
Simulation into_canonical_nullable[(10000, 100, 0.0)] 4.3 ms 5.1 ms -15.8%
Simulation into_canonical_nullable[(10000, 1, 0.0)] 77 µs 69 µs +11.62%
Simulation into_canonical_nullable[(10000, 100, 0.1)] 6.8 ms 6 ms +13.49%
Simulation into_canonical_nullable[(10000, 10, 0.1)] 619.6 µs 704.4 µs -12.03%
Simulation decompress_bitpacking_late_filter[i16, 0.01] 199.8 µs 157.3 µs +27%
Simulation decompress_bitpacking_late_filter[i16, 0.0105] 200.6 µs 158.1 µs +26.87%
Simulation decompress_bitpacking_late_filter[i16, 0.02] 218.1 µs 175.6 µs +24.17%
Simulation decompress_bitpacking_late_filter[i16, 0.03] 235.6 µs 193.1 µs +21.98%
Simulation decompress_bitpacking_late_filter[i16, 0.04] 252.9 µs 210.6 µs +20.11%
Simulation decompress_bitpacking_late_filter[i16, 0.05] 270.3 µs 228 µs +18.53%
Simulation decompress_bitpacking_late_filter[i32, 0.01] 299.7 µs 212 µs +41.38%
Simulation decompress_bitpacking_late_filter[i32, 0.0105] 300.6 µs 212.8 µs +41.23%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS force-pushed the adamg/make-windows-really-unsafe branch from 3f40add to a6450ce Compare January 20, 2026 11:13
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS force-pushed the adamg/make-windows-really-unsafe branch from a6450ce to 29205c7 Compare January 20, 2026 11:17
@robert3005 robert3005 added the chore Release label indicating a trivial change label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.84%. Comparing base (630322d) to head (64d5fc2).
⚠️ Report is 2 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS force-pushed the adamg/make-windows-really-unsafe branch from 8186454 to a651fe2 Compare January 20, 2026 11:36
@AdamGS AdamGS changed the title Disable MS defender features Windows CI Jan 20, 2026
@AdamGS AdamGS force-pushed the adamg/make-windows-really-unsafe branch 5 times, most recently from b8ce9ab to ff72041 Compare January 20, 2026 12:22
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS force-pushed the adamg/make-windows-really-unsafe branch 2 times, most recently from bf2c15f to 1915fe3 Compare January 20, 2026 12:47
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS force-pushed the adamg/make-windows-really-unsafe branch from 1915fe3 to b95b0b7 Compare January 20, 2026 12:58
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change experiment Tests an idea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants