Skip to content

chore[duckdb]: clean up the duckdb exporters #6055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joseph-isaacs merged 8 commits into from
Jan 20, 2026
Merged

chore[duckdb]: clean up the duckdb exporters #6055

joseph-isaacs merged 8 commits into from
Jan 20, 2026

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Jan 20, 2026 •
edited
Loading

Support into_parts for more array using a custom parts struct

@joseph-isaacs joseph-isaacs requested a review from gatesn January 20, 2026 13:32
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 20, 2026 13:32
@joseph-isaacs joseph-isaacs added the chore Release label indicating a trivial change label Jan 20, 2026
@joseph-isaacs
clean
8271e6c 
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs
clean
389caaf 
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs
clean
e2a4589 
Signed-off-by: Joe Isaacs <[email protected]>
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026 •
edited
Loading

Merging this PR will improve performance by 13.81%

⚡ 2 improved benchmarks
✅ 1252 untouched benchmarks
⏩ 1254 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation bench_many_nulls[0.5] 365 µs 329.5 µs +10.76%
⚡ Simulation bench_many_nulls[0.9] 533 µs 468.3 µs +13.81%

Comparing ji/cleanup-duckdb-exporter-execute (993a392) with develop (cd9048d)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@joseph-isaacs
clean
a21fc0f 
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs
clean
a0c06cf 
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs
clean
2d53a71 
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs
clean
993a392 
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs merged commit 5b5a4af into develop Jan 20, 2026
45 of 46 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/cleanup-duckdb-exporter-execute branch January 20, 2026 15:36
blaginin
blaginin reviewed Jan 20, 2026
View reviewed changes
vortex-error/src/lib.rs
#[inline(always)]
fn vortex_expect(self, msg: &'static str) -> Self::Output {
self.map_err(|err| err.into())
.inspect_err(|e| println!("got a big ERROR {e}"))
Copy link
Member

@blaginin blaginin Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

blaginin
blaginin reviewed Jan 20, 2026
View reviewed changes
vortex-duckdb/src/lib.rs

let conn = database
.connect()
.inspect_err(|e| println!("err {e}"))
Copy link
Member

@blaginin blaginin Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blaginin blaginin blaginin left review comments

@gatesn gatesn gatesn approved these changes

Assignees

No one assigned

Labels

chore Release label indicating a trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joseph-isaacs @gatesn @blaginin