Migrate WASM Arrow conversion to use VortexSession#8619
Merged
Conversation
Replace the deprecated `ArrowArrayExecutor::execute_arrow` trait and the deprecated `DType::to_arrow_dtype` method with the plugin-aware `ArrowSession` methods reached via `session.arrow()`. `dtype_to_schema` and `array_to_record_batch` now take the file's `VortexSession` and route Arrow schema/field/array conversions through `ArrowSession`, dropping the reliance on the hidden global `LEGACY_SESSION`. Because the session path dispatches extension plugins, extension metadata (e.g. UUID) is preserved instead of being silently stripped. Signed-off-by: Robert <robert@spiraldb.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uguf32FtyCKryWCXjA59DM
0ax1
approved these changes
Jun 29, 2026
Merging this PR will improve performance by 10.35%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | eq_i64_constant |
318.9 µs | 289 µs | +10.35% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/vortex-web-arrowsession-sttq57 (8d099fc) with develop (733ab9e)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop using deprecated api