Skip to content

Replace MaybeUninit transmutes with write_copy_of_slice - #9814

Open
robert3005 wants to merge 3 commits into
developfrom
rk/uninitwriteslice
Open

Replace MaybeUninit transmutes with write_copy_of_slice#9814
robert3005 wants to merge 3 commits into
developfrom
rk/uninitwriteslice

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This also fixes a bug in BufferMut where extend_from_slice copied non copy types

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
Comment thread vortex-array/src/arrays/fixed_width/take/slices.rs
@codspeed-hq

codspeed-hq Bot commented Sep 9, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 1.55%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
❌ 7 regressed benchmarks
✅ 2175 untouched benchmarks
🆕 6 new benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation random_i8[0.8] 69.9 µs 97.3 µs -28.12%
WallTime filtered_sink_i64_avx512[NineNullsInTen] 16.2 µs 18.3 µs -11.57%
WallTime filtered_owned_i64_avx2[NineNullsInTen] 13.2 µs 14.9 µs -11.1%
WallTime mul_i32_nonnull_avx512 7 µs 7.9 µs -10.83%
Simulation patterns_i128[Runs] 106.8 µs 119.7 µs -10.79%
Simulation random_i128[0.8] 170.9 µs 191.6 µs -10.79%
WallTime filtered_owned_i64_avx512[NineNullsInTen] 13.5 µs 15.1 µs -10.58%
Simulation random_i8[0.5] 91.4 µs 65.6 µs +39.44%
WallTime filtered_owned_i64_avx512[OneNullInEight] 26.3 µs 22.1 µs +18.76%
Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%
WallTime mul_u32_nonnull_avx512 6.2 µs 5.6 µs +11.48%
Simulation allocate_drop_bytes[0] 575.7 ns 521.6 ns +10.39%
🆕 WallTime dict_canonicalize_gt_u8_neon[1000000] N/A 542.4 µs N/A
🆕 WallTime dict_canonicalize_gt_u8_neon[16000000] N/A 8.7 ms N/A
🆕 WallTime dict_canonicalize_gt_u8_avx2[1000000] N/A 419.8 µs N/A
🆕 WallTime dict_canonicalize_gt_u8_avx2[16000000] N/A 6.8 ms N/A
🆕 WallTime dict_canonicalize_gt_u8_avx512[1000000] N/A 419.3 µs N/A
🆕 WallTime dict_canonicalize_gt_u8_avx512[16000000] N/A 6.8 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/uninitwriteslice (ee0fda0) with develop (ae8fddc)2

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (2a5b1a7) during the generation of this report, so ae8fddc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Comment thread vortex-buffer/src/buffer_mut.rs Outdated
Comment thread vortex-buffer/src/buffer_mut.rs Outdated
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 added this pull request to stack #9825 September 10, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants