Fix Gradle plugin release build: pass springdoc version via system pr… - #93
Merged
Conversation
…operty The functional tests hardcoded a 5.1.0-SNAPSHOT dependency on the springdoc starter artifacts. During a release, prepare-release-commit.sh rewrites gradle.properties to the release version (e.g. 5.1.0) and Maven installs that release version into the local repo, so the sample apps could not resolve the -SNAPSHOT coordinate and the Gradle :test task failed the release build. Pass the plugin project's resolved version to the tests via the springdocVersion system property (set in build.gradle from project.version) and interpolate it into the sample build.gradle dependency coordinates, falling back to 5.1.0-SNAPSHOT for local development. This keeps the tests in sync for both snapshots and releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…operty
The functional tests hardcoded a 5.1.0-SNAPSHOT dependency on the springdoc starter artifacts. During a release, prepare-release-commit.sh rewrites gradle.properties to the release version (e.g. 5.1.0) and Maven installs that release version into the local repo, so the sample apps could not resolve the -SNAPSHOT coordinate and the Gradle :test task failed the release build.
Pass the plugin project's resolved version to the tests via the springdocVersion system property (set in build.gradle from project.version) and interpolate it into the sample build.gradle dependency coordinates, falling back to 5.1.0-SNAPSHOT for local development. This keeps the tests in sync for both snapshots and releases.