fix(VStepper): make step items clickable when non-linear prop is set#22957
Closed
sridhar-3009 wants to merge 1 commit into
Closed
fix(VStepper): make step items clickable when non-linear prop is set#22957sridhar-3009 wants to merge 1 commit into
sridhar-3009 wants to merge 1 commit into
Conversation
Contributor
|
behavior might be revised in v5, but in v4 we only need docs change as described here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19275
Root cause
VStepperprovides defaults toVStepperItem(editable, icons, etc.) but never providednonLinear. As a result, inVStepperItem,isClickablewas computed as!props.disabled && props.editable— meaning thenonLinearprop had no effect on step navigation.Fix
VStepper.tsx: includenonLinearin theprovideDefaultsforVStepperItemVStepperItem.tsx: addnonLinearprop and updateisClickableto!disabled && (editable || nonLinear)disabledattribute and ripple on the button now useisClickableso non-linear steppers properly enable clicking without requiringeditableeditableandnonLinearremain independent:editablealso shows the edit icon on the active step,nonLinearonly enables click navigation.