feat(VSelectionControl): add text prop for description below label#22959
Open
sridhar-3009 wants to merge 6 commits into
Open
feat(VSelectionControl): add text prop for description below label#22959sridhar-3009 wants to merge 6 commits into
sridhar-3009 wants to merge 6 commits into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21773 — adds a
textprop tov-checkbox(and all other selection controls) that renders a description below the checkbox label.Changes
VSelectionControl.tsx: addtext: Stringprop andtextslot; wrap label + text in.v-selection-control__contentflex-column containerVSelectionControl.sass: add styles for.v-selection-control__contentand.v-selection-control__text_variables.scss: add$selection-control-text-font-size(0.875rem) and$selection-control-text-colorSASS variablesprop-textexample and section forv-checkboxUsage
<v-checkbox label="Subscribe to newsletter" text="You'll receive weekly updates about new features and releases." />The
textslot can be used for rich content:Test plan
v-checkboxwith thetextprop — description should appear below the labeltextslot override worksv-radioandv-switchalso accept the prop (as they shareVSelectionControl)textis not set