feat(VFileInput): add placeholder and persistent-placeholder props#22960
Open
sridhar-3009 wants to merge 5 commits into
Open
feat(VFileInput): add placeholder and persistent-placeholder props#22960sridhar-3009 wants to merge 5 commits into
sridhar-3009 wants to merge 5 commits into
Conversation
J-Sek
requested changes
Jun 28, 2026
J-Sek
left a comment
Contributor
There was a problem hiding this comment.
- rebase and target
devbranch - ideally we could overlay text input on top, so universal styles for
::placeholderwould match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19837 — adds
placeholderandpersistent-placeholderprops tov-file-input, similar tov-text-field.Changes
VFileInput.tsx: addplaceholder: StringandpersistentPlaceholder: Booleanprops; render placeholder text when no file is selected; includepersistentPlaceholderinisActiveso the label floatsVFileInput.sass: add.v-file-input__placeholderstyle_variables.scss: add$file-input-placeholder-colorSASS variableUsage
Test plan
placeholdertov-file-input— text should appear when no file is chosenpersistent-placeholderkeeps the label floated so placeholder remains visibleplaceholderis omitted