fix(VListItem): only attach onClick when item is clickable#22967
Open
sridhar-3009 wants to merge 6 commits into
Open
fix(VListItem): only attach onClick when item is clickable#22967sridhar-3009 wants to merge 6 commits into
sridhar-3009 wants to merge 6 commits into
Conversation
…r has click handler (vuetifyjs#22854)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22854
Problem
NVDA and other screen readers detect VListItem as "clickable" even when the item has no interactive functionality. This happens because
onClick={ onClick }was always attached unconditionally to every VListItem, causing screen readers to announce all list items as interactive/clickable.Fix
Made the
onClicklistener conditional:The listener is now only attached when:
isClickable.value— has a link, is selectable, etc.)@clickhandler (attrs.onClick)The
emit('click', e)still fires in both cases since it's inside theonClickfunction.