fix(docs): make Agent docs review the only gate by rachaelrenk · Pull Request #688 · warpdotdev/docs

rachaelrenk · 2026-09-04T21:25:55Z

Summary

Makes the required Agent docs review status check the only automated merge gate. Bot review results remain visible on the PR, but they no longer create a sticky GitHub CHANGES_REQUESTED state.

Changes

Publishes every independent-agent verdict as a non-blocking GitHub review comment.
Dismisses only stale CHANGES_REQUESTED reviews created by github-actions[bot]; human reviews and the current commit's review remain untouched.
Adds regression coverage for comment-only review events, hidden parseable signals, and stale-review selection.

Unverified claims

None — this changes internal documentation-review automation only.

Documentation risk

Risk: low
Rationale: This internal review-workflow change removes stale bot review states without changing public product documentation.
Docs override: none

Validation

python3 .agents/skills/doc_quality_policy/test_publish_review_signal.py — passed (4 tests).
python3 .agents/skills/doc_quality_policy/test_verify_review_signal.py — passed (14 tests).
python3 .agents/skills/doc_quality_policy/test_stale_review_requests.py — passed.
Workflow YAML parsed successfully.

Co-Authored-By: Warp agent@warp.dev

Co-Authored-By: Warp <agent@warp.dev>

vercel · 2026-09-04T21:25:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 8, 2026 8:56pm UTC

warp-for-oss · 2026-09-04T21:26:08Z

@rachaelrenk

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

warp-for-oss

Overview

This PR changes the agent-docs review publisher to submit non-blocking review comments and adds a workflow step/script to dismiss stale automated change-request reviews.

Concerns

The stale-review dismissal step only reads the first page of pull request reviews, so a long-lived PR can keep an older bot change-request review on a later page and still be blocked by GitHub review state.
The dismissal pipeline can mask failures from the Python selector under the workflow's default shell behavior, leaving stale review states in place while later steps continue.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

warp-for-oss · 2026-09-04T21:31:14Z

+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          gh api "repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews?per_page=100" > /tmp/reviews.json


⚠️ [IMPORTANT] This fetch only reads the first 100 reviews, so a long-lived agent PR can retain a stale CHANGES_REQUESTED review on a later page and still keep GitHub's review gate blocking merge after this step completes. Paginate and slurp all pages before passing them to stale_review_requests.py.

warp-for-oss · 2026-09-04T21:31:14Z

+          python3 .agents/skills/doc_quality_policy/stale_review_requests.py \
+            --reviews /tmp/reviews.json \
+            --head-sha "${{ github.event.pull_request.head.sha }}" |
+            while IFS= read -r review_id; do


⚠️ [IMPORTANT] If stale_review_requests.py exits non-zero, this pipeline can still succeed under the default implicit bash shell because only the while loop's status is checked; that would skip dismissals without failing the workflow. Enable pipefail or write the selected IDs to a temp file before looping.

github-actions

Review summary

The independent agent completed its review for this commit.

Findings

risk-classification (1)
doc-drift (1)
ci-pagination (1)

Verdict

Request changes

github-actions

Review summary

The independent agent completed its review for this commit.

Findings

stale-review-instructions (1)
dismissal-pagination-gap (1)
pr-body-overstatement (1)

Verdict

Request changes

github-actions

Review summary

The independent agent completed its review for this commit.

Findings

ci-workflow-error-handling (1)
api-pagination (1)

Verdict

Approve

Co-Authored-By: Warp <agent@warp.dev>

rachaelrenk · 2026-09-08T20:42:31Z

/warp-agent-review

warp-for-oss · 2026-09-08T20:42:44Z

@rachaelrenk

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

warp-for-oss

Overview

This PR changes the agent-docs review workflow so independent-agent verdicts publish as non-blocking GitHub review comments, while the required workflow check remains the merge gate. It adds a focused helper and tests for dismissing stale automated change-request reviews without touching human reviews or reviews on the current head commit.

Concerns

No blocking correctness, security, test-quality, comment-quality, or documentation-risk concerns found in the annotated diff.
spec_context.md reports no approved or repository spec context, so there was no material spec commitment to compare against.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

github-actions

Review summary

The independent agent completed its review for this commit.

Findings

skill-doc-consistency (1)

Verdict

Approve

Co-Authored-By: Warp <agent@warp.dev>

rachaelrenk · 2026-09-08T20:52:54Z

/warp-agent-review

warp-for-oss · 2026-09-08T20:53:07Z

@rachaelrenk

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

warp-for-oss

Overview

This PR changes the Agent docs review publisher so independent-agent verdicts are posted as non-blocking GitHub review comments, and adds a helper/workflow step to dismiss stale automated change-request reviews from older heads. The attached tests cover the new comment-only event mapping and stale-review selection behavior.

Concerns

No blocking concerns found in the attached diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

github-actions

Review summary

The independent agent completed its review for this commit.

Findings

ci-workflow-robustness (1)
risk-classification-verified (1)

Verdict

Approve with nits

fix(docs): gate agent reviews by check status

d45875f

Co-Authored-By: Warp <agent@warp.dev>

cla-bot Bot added the cla-signed label Sep 4, 2026

rachaelrenk added the warpy-factory Opened by the Warp factory agents label Sep 4, 2026

vercel Bot deployed to Preview September 4, 2026 21:29 View deployment

warp-for-oss Bot reviewed Sep 4, 2026

View reviewed changes

github-actions Bot reviewed Sep 4, 2026

View reviewed changes

hongyi-chen added 2 commits September 7, 2026 22:26

Merge branch 'main' into rachaelrenk/agent-docs-review-check-only

d8b5d2c

Merge branch 'main' into rachaelrenk/agent-docs-review-check-only

91b938d

vercel Bot deployed to Preview September 8, 2026 05:32 View deployment

github-actions Bot reviewed Sep 8, 2026

View reviewed changes

Merge branch 'main' into rachaelrenk/agent-docs-review-check-only

ac7a729

vercel Bot deployed to Preview September 8, 2026 20:22 View deployment

github-actions Bot reviewed Sep 8, 2026

View reviewed changes

fix(docs): harden stale review cleanup

44910d4

Co-Authored-By: Warp <agent@warp.dev>

vercel Bot deployed to Preview September 8, 2026 20:45 View deployment

warp-for-oss Bot reviewed Sep 8, 2026

View reviewed changes

github-actions Bot reviewed Sep 8, 2026

View reviewed changes

Merge branch 'main' into rachaelrenk/agent-docs-review-check-only

03c4b29

Co-Authored-By: Warp <agent@warp.dev>

vercel Bot deployed to Preview September 8, 2026 20:56 View deployment

warp-for-oss Bot reviewed Sep 8, 2026

View reviewed changes

github-actions Bot reviewed Sep 8, 2026

View reviewed changes

Uh oh!

Conversation

rachaelrenk commented Sep 4, 2026

Summary

Changes

Unverified claims

Documentation risk

Validation

Uh oh!

vercel Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

warp-for-oss Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

warp-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

warp-for-oss Bot Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

warp-for-oss Bot Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Review summary

Findings

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Review summary

Findings

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Review summary

Findings

Verdict

Uh oh!

rachaelrenk commented Sep 8, 2026

Uh oh!

warp-for-oss Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

warp-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Review summary

Findings

Verdict

Uh oh!

rachaelrenk commented Sep 8, 2026

Uh oh!

warp-for-oss Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

warp-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Review summary

Findings

Verdict

Uh oh!

Reviewers

vercel Bot commented Sep 4, 2026 •

edited

Loading

warp-for-oss Bot commented Sep 4, 2026 •

edited

Loading

warp-for-oss Bot commented Sep 8, 2026 •

edited

Loading

warp-for-oss Bot commented Sep 8, 2026 •

edited

Loading