Trigger log search when pressing Enter in the filter field#978
Open
GrzegorzSidwa wants to merge 1 commit into
Open
Trigger log search when pressing Enter in the filter field#978GrzegorzSidwa wants to merge 1 commit into
GrzegorzSidwa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pressing Enter in the "Search logs…" filter field now runs the search, so users no longer have to click the Search button every time.
The input and buttons are wrapped in a
<form ng-submit="vm.search(...)">, and the Search button is changed totype="submit". The Clear button staystype="button"so it does not submit the form. AngularJS handlespreventDefault()automatically (the form has noaction), so there is no page reload.Testing
Built the .NET server + Electron client and verified in the running app: typing text and pressing Enter triggers the search, the Search button still works on click, and Clear behaves as before.