feat: Add BaseURL to Cohere Reranker config#287
Open
mpartipilo wants to merge 1 commit intov1.0.1from
Open
Conversation
Adds `BaseURL` property to `Reranker.Cohere` and updates `RerankerConfigFactory.Cohere()` to accept `baseURL` parameter, matching the pattern already used by `Reranker.Nvidia` and aligning with the Python client implementation. Closes #230 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 60.7%
Weaviate.Client.Analyzers - 91.4%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseURLproperty toReranker.Cohererecord, following the same pattern already used byReranker.NvidiaRerankerConfigFactory.Cohere()to accept an optionalbaseURLparameterPublicAPI.Unshipped.txtwith new API surfaceCloses #230
Test plan
Cohere_Reranker_Has_BaseURL_Property— verifies property can be setCohere_Reranker_BaseURL_Defaults_To_Null— verifies null defaultRerankerConfigFactory_Cohere_Accepts_BaseURL— verifies factory wires the valueRerankerConfigFactory_Cohere_Accepts_BaseURL_And_Model— verifies both params work togetherCohere_Reranker_BaseURL_Is_Serialized_To_JSON— verifies serialization🤖 Generated with Claude Code