Skip to content

fix: disable mic AGC by default to stop Windows audio crackle #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdu11ahbaig wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Open

fix: disable mic AGC by default to stop Windows audio crackle #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion electron/ipc/register/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
import { parseJsonWithByteOrderMark } from "../utils";

const BROWSER_MICROPHONE_PROFILE_ENV = "RECORDLY_BROWSER_MIC_PROFILE";
const DEFAULT_BROWSER_MICROPHONE_PROFILE = "processed";
const DEFAULT_BROWSER_MICROPHONE_PROFILE = "no-agc";
const recordingPreferencesStore = createRecordingPreferencesStore(RECORDINGS_SETTINGS_FILE);
const BROWSER_MICROPHONE_PROFILES = new Set([
"processed",
Expand Down
12 changes: 6 additions & 6 deletions src/hooks/useScreenRecorder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ function createMockMediaRecorder(initialState: RecordingState = "inactive") {
}

describe("createProcessedMicrophoneConstraints", () => {
it("requests browser voice processing with AGC for the default microphone", () => {
it("requests browser voice processing without AGC for the default microphone", () => {
expect(createProcessedMicrophoneConstraints()).toEqual({
audio: {
echoCancellation: true,
noiseSuppression: true,
autoGainControl: true,
autoGainControl: false,
channelCount: { ideal: 1 },
sampleRate: { ideal: 48000 },
},
Expand All @@ -53,7 +53,7 @@ describe("createProcessedMicrophoneConstraints", () => {
deviceId: { exact: "device-123" },
echoCancellation: true,
noiseSuppression: true,
autoGainControl: true,
autoGainControl: false,
channelCount: { ideal: 1 },
sampleRate: { ideal: 48000 },
},
Expand Down Expand Up @@ -105,10 +105,10 @@ describe("createProcessedMicrophoneConstraints", () => {
});
});

it("normalizes invalid lab microphone profiles to production voice processing", () => {
it("normalizes invalid lab microphone profiles to the default voice processing", () => {
expect(normalizeBrowserMicrophoneProfile("RAW")).toBe("raw");
expect(normalizeBrowserMicrophoneProfile("unknown")).toBe("processed");
expect(normalizeBrowserMicrophoneProfile(null)).toBe("processed");
expect(normalizeBrowserMicrophoneProfile("unknown")).toBe("no-agc");
expect(normalizeBrowserMicrophoneProfile(null)).toBe("no-agc");
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useScreenRecorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export type BrowserCaptureCursorPolicy = {
hideOsCursorBeforeRecording: boolean;
hideEditorOverlayCursorByDefault: boolean;
};
const DEFAULT_BROWSER_MICROPHONE_PROFILE: BrowserMicrophoneProfile = "processed";
const DEFAULT_BROWSER_MICROPHONE_PROFILE: BrowserMicrophoneProfile = "no-agc";
const BROWSER_MICROPHONE_PROFILES = new Set<BrowserMicrophoneProfile>([
"processed",
"no-agc",
Expand Down