Fix/linux hud menu clipping - #945
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe HUD overlay fallback path in ChangesHUD overlay behavior
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The HUD fallback change matches the intended Linux menu visibility fix without introducing a concrete merge-blocking risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Fixes dropdown menus (Camera, Microphone, Language, Timer) rendering clipped/behind the recording bar on Linux by restoring HUD window expansion for popovers.
Motivation
On Linux, the HUD overlay window doesn't support mouse-passthrough, so it stays compact (160px) and is supposed to expand (540px) when a popover opens. A leftover
process.platform !== "linux"guard insetHudOverlayMousePassthrough(electron/windows.ts) made that expansion dead code on Linux.. the only platform that hits it, so the window never grew and popover content got clipped behind the recording bar. Removing the guard restores the intended behavior.Type of Change
Related Issue(s)
Fixes #931
Screenshots / Video
Testing Guide
Checklist
Summary by CodeRabbit