Skip to content

Fix/linux hud menu clipping - #945

Open
abdu11ahbaig wants to merge 2 commits into
webadderallorg:mainfrom
abdu11ahbaig:fix/linux-hud-menu-clipping
Open

Fix/linux hud menu clipping#945
abdu11ahbaig wants to merge 2 commits into
webadderallorg:mainfrom
abdu11ahbaig:fix/linux-hud-menu-clipping

Conversation

@abdu11ahbaig

@abdu11ahbaig abdu11ahbaig commented Sep 13, 2026

Copy link
Copy Markdown

Description

Fixes dropdown menus (Camera, Microphone, Language, Timer) rendering clipped/behind the recording bar on Linux by restoring HUD window expansion for popovers.

Motivation

On Linux, the HUD overlay window doesn't support mouse-passthrough, so it stays compact (160px) and is supposed to expand (540px) when a popover opens. A leftover process.platform !== "linux" guard in setHudOverlayMousePassthrough (electron/windows.ts) made that expansion dead code on Linux.. the only platform that hits it, so the window never grew and popover content got clipped behind the recording bar. Removing the guard restores the intended behavior.

Type of Change

  • New Feature
  • Bug Fix
  • Refactor / Code Cleanup
  • Documentation Update
  • Other (please specify)

Related Issue(s)

Fixes #931

Screenshots / Video

Testing Guide

  1. On Linux (X11 or Wayland), launch Recordly and open the recording HUD.
  2. Click each of Camera, Microphone, Language, and Timer.
  3. Confirm each dropdown renders fully above the recording bar, with no options cut off.
  4. Open the screen/window source picker and confirm it still behaves normally (no unexpected HUD resizing while it's open).
  5. Start a recording and confirm the HUD still collapses/behaves as expected (fallback expansion is disabled while recording is active).

Checklist

  • I have performed a self-review of my code.
  • I have added any necessary screenshots or videos.
  • I have linked related issue(s) and updated the changelog if applicable.

Summary by CodeRabbit

  • Refactor
    • Simplified desktop overlay interaction handling without changing user-facing behavior or public APIs.
    • Existing fallback expansion behavior remains consistent on supported platforms.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1f281378-c570-4986-ba27-bae099fbfdb2

📥 Commits

Reviewing files that changed from the base of the PR and between 8b9b106 and 0948979.

📒 Files selected for processing (1)
  • electron/windows.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The HUD overlay fallback path in electron/windows.ts no longer uses a redundant non-Linux guard. The fallback expansion call remains limited to platforms where mouse passthrough is unsupported.

Changes

HUD overlay behavior

Layer / File(s) Summary
Remove redundant fallback guard
electron/windows.ts
setHudOverlayFallbackExpanded(!ignore) now runs directly inside the existing unsupported mouse passthrough branch. Public APIs remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: webadderall

Merge Risk: ⚪ Minimal · up to 09489

The HUD fallback change matches the intended Linux menu visibility fix without introducing a concrete merge-blocking risk.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ⚠️ Warning The linked issue is unrelated to this pull request. Issue #931 concerns repeated, low-pitched microphone audio on Windows, while this pull request fixes Linux HUD menu clipping. Link an issue that tracks the Linux HUD menu clipping problem, or remove the unrelated issue link and explain why no related issue exists.
✅ Passed checks (3 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed The one-line change in electron/windows.ts directly supports the stated objective of restoring Linux HUD expansion for dropdown menus. No unrelated changes are described.
Title check ✅ Passed The title clearly identifies the Linux HUD menu clipping fix, which matches the primary change.
Description check ✅ Passed The description includes the purpose, motivation, bug-fix classification, related issue, testing steps, and checklist. It also explains why screenshots are unavailable.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audio recording issue

1 participant