Repository navigation
Remove dead code #1
Description
I removed most of the code that we don't need, but i think there are some files that we can delete too, I will create a list here of which files that we need to remove, but that needs to be tested.
inside include folder:
-
AR folder:
- arosg.h
- gsub.h, gsubConfig.h, gsub_es.h. gsub_es2.h, gsub_lite.h
- video.h, videoConfig.h, VideoLuma.h, VideoRGBA.h
-
ARUtil folder:
- android.h
- thread_sub.h
-
ARWrapper folder:
i left this but not sure what to do with this. -
Eden folder:
does we need this? -
glStateCache.h and glStateCache2.h
inside lib/SRC folder:
-
AR folder:
- ref. files to Pattern Marker? what other?
-
ARUtil folder:
as for the include folder files tat refer to android and threading
to be completed...
Activity
kalwalt commentedon May 13, 2020
We can also remove all the Makefiles, if we think that we will not build the libs with the makefile system.
There is another question I ask myself: if webarkitLib will be used also by jsartoolkit5 I cannot go to remove certain files concerning Pattern, Barcode or Mult Markers, in this case I have to see how much to go deep in cleaning.
ThorstenBux commentedon May 13, 2020
kalwalt commentedon May 15, 2020
Eden has been removed with this commit 0ec0048 see also #2 (comment)
subjectdenied commentedon May 17, 2020
wouldn't it be better to integrate (work on the build-system of the original artoolkit) webarkit/jsartoolkit/ into artoolkit and allow artoolkit to be built for "web", instead of forking in a way merging the "web" artoolkit with the "desktop" artoolkit will be amost impossible in the future?
kalwalt commentedon May 17, 2020
@subjectdenied we want to develop a new lib that is based in part on the original Artoolkit5 - ArtoolkitX and oter features. Consider that actually the ARtoolkit5 repository is more than 500 mb but the code required to buld jsartoolkit5 it's around 8mb. Does make sense?