Repository navigation
new expanded element composite section - #967
Conversation
…/webforj-documentation into expand-element-composite
… and added clarification on "leaf node"
gosteenBASIS
left a comment
There was a problem hiding this comment.
Generally in good shape I think, but I left a couple comments where I think some clarification/edits would help.
The only big thing is that Shoelace is being converted to Web Awesome, so I think it would be a good idea to update all the examples/prose to use Web Awesome instead, so as to be up to date with the latest developments in that area. That would be a moderate overhaul of all the examples, so I'll leave it up to Lauren or Hyyan to decide if that's the right call!
|
@MatthewHawkins please review this and leave your comments, then assign it back to me. |
|
Pushed updates addressing the review feedback. Property and attribute descriptors
Article structure
CardView demo
Follow-up Shoelace has been sunset in favor of Web Awesome, so the demos will need to migrate. I'll open a separate issue to track that since it touches all four demo files and needs the current Web Awesome release status verified. |
|
@laurenic0l Looks great! Could you link the issues that this PR will close before we merge it? |
|
@laurenic0l My mistake - I merged this after reading Hyyan's email but before I read his comment to close out the issues. Go ahead and list the issues here and manually close them out, sorry! |
PR for the new expanded elementcomposite section
closes #710
closes #378
closes #376