Skip to content

new expanded element composite section - #967

Merged
MatthewHawkins merged 13 commits into
mainfrom
expand-element-composite
Jun 19, 2026
Merged

MatthewHawkins merged 13 commits into
mainfrom
expand-element-composite

Conversation

@laurenic0l

@laurenic0l laurenic0l commented May 7, 2026 •

Copy link
Copy Markdown
Contributor

PR for the new expanded elementcomposite section

closes #710
closes #378
closes #376

Comment thread docs/docs/building-ui/element-composite.md Outdated
Comment thread docs/docs/building-ui/element-composite.md Outdated
Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md Outdated
@laurenic0l laurenic0l added the status: waiting-for-review The PR is ready. Waiting for team members to review. label May 11, 2026

@gosteenBASIS gosteenBASIS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally in good shape I think, but I left a couple comments where I think some clarification/edits would help.
The only big thing is that Shoelace is being converted to Web Awesome, so I think it would be a good idea to update all the examples/prose to use Web Awesome instead, so as to be up to date with the latest developments in that area. That would be a moderate overhaul of all the examples, so I'll leave it up to Lauren or Hyyan to decide if that's the right call!

Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md Outdated
Comment thread docs/docs/building-ui/element-composite.md Outdated
@hyyan hyyan assigned MatthewHawkins and unassigned hyyan May 19, 2026
@hyyan

hyyan commented May 19, 2026

Copy link
Copy Markdown
Member

@MatthewHawkins please review this and leave your comments, then assign it back to me.

Comment thread docs/docs/building-ui/element-composite.md Outdated
Comment thread docs/docs/building-ui/element-composite.md Outdated
Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md Outdated
Comment thread docs/docs/building-ui/element-composite.md Outdated
Comment thread docs/docs/building-ui/element-composite.md
@laurenic0l
laurenic0l requested a review from MatthewHawkins May 20, 2026 21:43
Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md
Comment thread src/main/resources/static/element-composite/activityfeed.css Outdated
Comment thread docs/docs/building-ui/element-composite.md
Comment thread docs/docs/building-ui/element-composite.md
Comment thread src/main/java/com/webforj/samples/views/elementcomposite/CardView.java Outdated
Comment thread docs/docs/building-ui/element-composite.md
@hyyan hyyan added status: waiting-for-author Review is done. Waiting for the PR author to apply changes or respond. and removed status: waiting-for-review The PR is ready. Waiting for team members to review. labels May 29, 2026
Comment thread docs/docs/building-ui/element-composite.md
@laurenic0l

Copy link
Copy Markdown
Contributor Author

Pushed updates addressing the review feedback.

Property and attribute descriptors

  • Added explicit factory method syntax for PropertyDescriptor.property() and PropertyDescriptor.attribute()
  • Added full declaration syntax to the Typing properties subsection
  • Rewrote set()/get() to explain the protected primitives, the server-side cache, and the Type resolution order

Article structure

  • Wrapped event content under a single ## Events heading
  • Nested Testing properties under Property and attribute descriptors
  • Restructured Interacting with slots to lead with adding content and ElementCompositeContainer, demoted inspection methods to a short subsection at the end
  • Narrowed Built-in event classes to ElementClickEvent and the HasElementClickListener concern

CardView demo

  • Replaced the nonexistent --dwc-color-neutral-600 with --dwc-color-default-text-light
  • Applied ButtonTheme.PRIMARY to the CTA button
  • Centered the cards vertically and fixed dark-mode background through the Shoelace shadow DOM

Follow-up

Shoelace has been sunset in favor of Web Awesome, so the demos will need to migrate. I'll open a separate issue to track that since it touches all four demo files and needs the current Web Awesome release status verified.

@laurenic0l
laurenic0l requested a review from hyyan June 18, 2026 12:26
@laurenic0l laurenic0l added status: waiting-for-review The PR is ready. Waiting for team members to review. and removed status: waiting-for-author Review is done. Waiting for the PR author to apply changes or respond. labels Jun 18, 2026
@hyyan

hyyan commented Jun 19, 2026

Copy link
Copy Markdown
Member

@laurenic0l Looks great! Could you link the issues that this PR will close before we merge it?

@MatthewHawkins
MatthewHawkins merged commit fb92859 into main Jun 19, 2026
1 of 2 checks passed
@MatthewHawkins
MatthewHawkins deleted the expand-element-composite branch June 19, 2026 14:53
@MatthewHawkins

Copy link
Copy Markdown
Member

@laurenic0l My mistake - I merged this after reading Hyyan's email but before I read his comment to close out the issues. Go ahead and list the issues here and manually close them out, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-review The PR is ready. Waiting for team members to review.

Projects

None yet

4 participants