Merged
Conversation
stempler
reviewed
Feb 25, 2026
Member
stempler
left a comment
stempler
left a comment
There was a problem hiding this comment.
I think the process for downloading the tools could be simplified. Using the release ID for gitleaks looks like something that can probably not be combined with renovate.
Both jq and gitleaks can be installed via mise.
So for example the mise-action could be used:
Option 1: Set up mise but do not install tools (as other tools potentially configured for mise in the repo are not needed), use mise exec to run jq and gitleaks commands.
Option 2: Set up mise and add jq and gitleaks to install_args so they are installed.
movabo
force-pushed
the
feat/ING-5087-secret-scanning
branch
from
914561a to
da10539
Compare
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ING-5087