fix(drawer): add MUI skeleton placeholders for politician drawer#4737
Open
Almee98 wants to merge 1 commit intowevote:developfrom
Open
fix(drawer): add MUI skeleton placeholders for politician drawer#4737Almee98 wants to merge 1 commit intowevote:developfrom
Almee98 wants to merge 1 commit intowevote:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix? WV-476
Summary
Adds MUI skeleton placeholders to the politician/candidate detail drawer (OrganizationModal) to keep layout stable and reduce layout shift while content loads.
Changes
New
OrganizationModal
PoliticianCardForList
CardForListBody
politicalPartyis falsyCampaignSupportThermometer
flex: 1,min-width: 0on HeartDetailsWrapper)HeartFavoriteToggleLoader
VoterPositionEntryAndDisplay
Future Work
To achieve a smoother transition from skeleton to loaded content, a larger refactor of the drawer’s data flow and loading architecture will be needed. I’d like to talk about this in our next meeting.
Testing