Reject TreeRewriter ranges from another source buffer - #1094
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
Contributor
|
No objection, it could be better to be strict about this. I'd add a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject rewrite actions whose
Parser::Source::Rangebelongs to a differentSource::Buffer.Reproduction
The offsets happen to fit, so the foreign range silently rewrites unrelated target bytes. Importing another rewriter already checks buffer identity; direct public rewrite actions should enforce the same invariant.
Verification
ArgumentError; normal/import behavior remains covered by the full suiteThis is source-only and does not change valid same-buffer rewrites.