feat: serialise / deserialise acquisition flow [WPB-25018]#2118
Merged
Conversation
typfel
force-pushed
the
jacob/feat/serialise-aquisition-flow
branch
from
67bdc07 to
ace9a89
Compare
coriolinus
reviewed
May 7, 2026
coriolinus
left a comment
coriolinus
left a comment
Contributor
There was a problem hiding this comment.
The approach seems reasonable. IIRC it's basically what we talked about earlier, discussing this topic.
Comment on lines
+186
to
+187
| let snapshot = wire_e2e_identity::X509CredentialAcquisition::<states::DpopChallengeCompleted>::deserialize(Arc::new(pki_environment.as_ref().clone().into()), bytes) | ||
| .map_err(CoreCryptoError::generic())?; |
Contributor
There was a problem hiding this comment.
As long as we know that we'll only ever deserialize this from states::DpopChallengeCompleted then this is fine. But if we ever try to deserialize it from another state, this will fail in a confusing way.
istankovic
reviewed
May 7, 2026
typfel
force-pushed
the
jacob/feat/serialise-aquisition-flow
branch
from
ace9a89 to
0febefd
Compare
typfel
changed the title
typfel
force-pushed
the
jacob/feat/serialise-aquisition-flow
branch
from
bb74889 to
92ab233
Compare
typfel
force-pushed
the
jacob/feat/serialise-aquisition-flow
branch
4 times, most recently
from
1136646 to
22ca0c8
Compare
coriolinus
approved these changes
May 15, 2026
typfel
force-pushed
the
jacob/feat/serialise-aquisition-flow
branch
from
22ca0c8 to
9ff3765
Compare
istankovic
reviewed
May 18, 2026
| }; | ||
|
|
||
| #[derive(Debug)] | ||
| struct UnusedPkiEnvironmentHooks; |
Member
There was a problem hiding this comment.
@typfel Is there a reason we're not using DummyPkiEnvironmentHooks that we already have?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.