fix: start foreground CallService crashes [WPB-24829][WPB-24840]#4820
fix: start foreground CallService crashes [WPB-24829][WPB-24840]#4820saleniuk wants to merge 12 commits into
Conversation
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (54.02%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4820 +/- ##
===========================================
+ Coverage 51.29% 51.76% +0.46%
===========================================
Files 611 611
Lines 21201 21256 +55
Branches 3407 3410 +3
===========================================
+ Hits 10875 11003 +128
+ Misses 9310 9234 -76
- Partials 1016 1019 +3
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…rashes # Conflicts: # kalium
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|



https://wearezeta.atlassian.net/browse/WPB-24829
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
onStartCommandto avoid any delays.StartForegroundExceptionwith some more info to be able to better investigate crashes in the future.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Start a call, kill the app, open again. Disable microphone permissions and try to start or join a call. Starting the call should not crash.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.