Skip to content

fix: allow guests access to shared drive - WPB-25247#4742

Merged
jullianm merged 9 commits into
developfrom
fix/allow-guests-access-to-shared-drive
May 22, 2026
Merged

fix: allow guests access to shared drive - WPB-25247#4742
jullianm merged 9 commits into
developfrom
fix/allow-guests-access-to-shared-drive

Conversation

@jullianm
Copy link
Copy Markdown
Contributor

WPB-25247

Issue

This PR allows guests to access conversations shared drives even if they're on a team with drive disabled.
Also added UI test.

Testing

  • Have userA on drive enabled team
  • Have userB from another team (drive disabled)
  • Connect both users
  • UserA creates a drive enabled group conv with userB
  • UserB should have access to shared drive on this group conv (drive tab should not show though)

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Results

2 052 tests   2 024 ✅  3m 1s ⏱️
  343 suites     28 💤
    2 files        0 ❌

Results for commit fc79833.

♻️ This comment has been updated with latest results.

Summary: workflow run #26234615682
Allure report (download zip): html-report-30199-fix_allow-guests-access-to-shared-drive

Copy link
Copy Markdown
Contributor

@WilhelmOks WilhelmOks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just left some questions

Comment thread WireUI/Sources/WireLocators/Locators.swift Outdated
Comment thread WireUI/Sources/WireLocators/Locators.swift
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@OlivellaO OlivellaO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jullianm jullianm added this pull request to the merge queue May 22, 2026
Merged via the queue into develop with commit 37f3861 May 22, 2026
14 checks passed
@jullianm jullianm deleted the fix/allow-guests-access-to-shared-drive branch May 22, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants