Skip SetConsoleCP when stdout is non-interactive#701
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
wixbot
added a commit
to wixtoolset/.github
that referenced
this pull request
Mar 25, 2026
robmen
approved these changes
Jun 9, 2026
auto-merge was automatically disabled
June 9, 2026 20:17
Pull request was converted to draft
auto-merge was automatically disabled
June 9, 2026 20:21
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stdout is a pipe (e.g. wixnative.exe spawned by wix.exe), SetConsoleCP/SetConsoleOutputCP may fail if the console subsystem has not been initialized. The failure path in ConsoleInitialize closes the stdin/stdout pipe handles, causing wixnative to exit and wix.exe to get IOException: The pipe is being closed.
This gates the SetConsoleCP calls on vfStdOutInteractive, which is already computed earlier in ConsoleInitialize. Pipe-based I/O does not use the console codepage — both sides handle UTF-8 encoding explicitly.
Fixes wixtoolset/issues#9267