Update hitch patch to fully fix test failures. - #355
Open
kareem-wolfssl wants to merge 2 commits into
Open
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
Updates the hitch_1.8.0.patch vendor patch to make Hitch’s upstream test suite pass reliably when built against wolfSSL, and to better document the remaining caveats around the wolfSSL/OpenSSL behavioral differences.
Changes:
- Refines build/configure logic to track NPN support and expose it to the test environment (
HITCH_HAVE_NPN). - Adjusts test scripts to avoid wolfSSL-specific TLS/cipher and client-cert flag mismatches (notably tests 13, 15, and 39).
- Expands patch header notes to document why these adjustments are needed and how to avoid stale-generated-parser failures in reused build trees.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.