Fix wolfSSL interop build by defining WOLFPKCS11_USER_SETTINGS#200
Merged
Conversation
The standalone interoperability test Makefile compiles the wolfPKCS11 sources without running ./configure, so the generated wolfpkcs11/options.h does not exist. Since pkcs11.h now includes <wolfpkcs11/options.h> unless WOLFPKCS11_USER_SETTINGS is defined, the build failed with a fatal missing-header error. Define WOLFPKCS11_USER_SETTINGS so pkcs11.h includes the local user_settings.h (already on the include path) instead of the generated options.h, restoring the pre-regression build behavior.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a standalone build regression in the wolfSSL interoperability test harness by ensuring wolfPKCS11 headers don’t require the generated wolfpkcs11/options.h when ./configure hasn’t been run.
Changes:
- Add
-DWOLFPKCS11_USER_SETTINGSto the interoperability test Makefile’s common preprocessor flags sowolfpkcs11/pkcs11.hincludes the localuser_settings.hinstead of<wolfpkcs11/options.h>.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone interoperability test Makefile compiles the wolfPKCS11 sources without running ./configure, so the generated wolfpkcs11/options.h does not exist. Since pkcs11.h now includes <wolfpkcs11/options.h> unless WOLFPKCS11_USER_SETTINGS is defined, the build failed with a fatal missing-header error.
Define WOLFPKCS11_USER_SETTINGS so pkcs11.h includes the local user_settings.h (already on the include path) instead of the generated options.h, restoring the pre-regression build behavior.