STM32H5 Fixes - Fixes DHCP issue broken in PR #65#71
Merged
danielinux merged 1 commit intowolfSSL:masterfrom Mar 6, 2026
Merged
STM32H5 Fixes - Fixes DHCP issue broken in PR #65#71danielinux merged 1 commit intowolfSSL:masterfrom
danielinux merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DHCP lease acquisition issues on STM32H5 by correcting socket local IP handling during DHCP request and improving STM32H563 bring-up diagnostics.
Changes:
- Reset DHCP UDP socket
local_ipafter sending DHCP request so ACK matching follows the correct receive path. - Add UART diagnostics (MAC print, DHCP init/timeout logging, ETH stats dump) and shorten DHCP timeout.
- Adjust DHCP polling delay/tick comments and update TLS client compile-time flag name in banner output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/wolfip.c | Clears DHCP socket local_ip after request send to avoid premature “offered IP” binding affecting ACK handling. |
| src/port/stm32h563/main.c | Adds UART helpers and richer DHCP/ETH diagnostics; tweaks polling delay/timeout and TLS client banner guard. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
danielinux
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.