Fix FIPS v6 build: cast away const for ed448 export call#10424
Open
lealem47 wants to merge 2 commits intowolfSSL:masterfrom
Open
Fix FIPS v6 build: cast away const for ed448 export call#10424lealem47 wants to merge 2 commits intowolfSSL:masterfrom
lealem47 wants to merge 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a FIPS v6 build failure in the Ed448 public-key DER export path by matching the existing FIPS-version-conditional casting pattern already used for Ed25519, ensuring compatibility with older FIPS function prototypes.
Changes:
- Add a
HAVE_FIPS && FIPS_VERSION3_LT(7,0,0)conditional cast when callingwc_ed448_export_public()fromwc_Ed448PublicKeyToDer(). - Adjust the Tailscale configure defaults to set
ENABLED_SP(instead ofenable_sp) when--enable-spwasn’t explicitly provided.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
wolfcrypt/src/asn.c |
Adds a FIPS-version-conditional cast to keep Ed448 public key DER export building under older FIPS variants. |
configure.ac |
Updates Tailscale-related configure defaults for SP enabling behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1659
to
1662
| then | ||
| enable_wolfguard=yes | ||
| test "x$enable_sp" = "x" && enable_sp="yes,256" | ||
| test "x$enable_sp" = "x" && ENABLED_SP="yes,256" | ||
| enable_opensslall=yes |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mirror the FIPS-version-conditional cast pattern used for wc_ed25519_export_public in wc_Ed25519PublicKeyToDer.
Latest ed448.h prototype recently added a const param causing the following error in FIPS v6:
Testing
./configure --enable-fips=v6 && make
Checklist