Repository navigation
PKCS7 additional sanity checks - #12086
Open
JacobBarthelmeh wants to merge 2 commits into
Open
JacobBarthelmeh wants to merge 2 commits into
JacobBarthelmeh wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the PKCS#7 input-validation changes and regression coverage.
No open issues 🎉
What changed in this PR
Tightens wolfCrypt’s PKCS#7 input validation and adds regression coverage for malformed signed and enveloped data.
Changes:
- Returns
ASN_PARSE_Ewhen the initial SignedData sequence cannot be parsed. - Rejects empty KTRI encrypted keys before allocation and decryption.
- Adds tests for malformed inputs and repeated verification failures.
| File | Description |
|---|---|
wolfcrypt/src/pkcs7.c |
Adds explicit parse errors for invalid SignedData sequences and empty encrypted keys. |
tests/api/test_pkcs7.h |
Declares and registers the two new regression tests. |
tests/api/test_pkcs7.c |
Tests malformed KTRI input and rejection of non-sequence SignedData input. |
Review effort: Balanced
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-12379 and F-16275