Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
On my computer the run time goes from 30.5s to 28.7s |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
|
miniBill
force-pushed
the
fix-infinite-loop
branch
from
4c9a61c to
f1f57df
Compare
Collaborator
Author
|
[draft as it depends on #255] |
miniBill
force-pushed
the
fix-infinite-loop
branch
from
f1f57df to
495d3e2
Compare
|
|
wolfadex
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The important commit is the caching one. It makes the computations fast enough that loops have a chance to get caught before exploding