Conversation
Replace S3 upload with Firebase App Distribution (FAD) for WordPress and Jetpack prototype builds. This aligns with other Android apps in the org (Day One, WooCommerce, Pocket Casts). Ref: AINFRA-1686 --- Generate with the help of Claude Code, https://code.claude.com Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
mokagio
requested review from
AliSoftware,
ParaskP7,
iangmaia and
wzieba
and removed request for
AliSoftware,
ParaskP7 and
iangmaia
There was a problem hiding this comment.
I added myself as tester for WordPress-Android using our MC Self-Serve tool, opened the invite email from my test Android phone, then was able to install and launch the Prototype Build from #22505 without any issue 👍
| ) | ||
|
|
||
| return if ENV['BUILDKITE_PULL_REQUEST'].nil? | ||
| return unless is_ci |
There was a problem hiding this comment.
Note: I first this change picked my attention because I noticed it was not checking about the build being on a PR anymore but instead about it being on CI in general (and thus would run the commands even for e.g. builds triggered on trunk, not on PRs). So I was about to comment about that unexpected behavior change.
But then I realized that the test "is it a PR" was (correctly) moved directly into the comment_on_pr_with_prototype_build_install_link helper (line 362–363), so this is all good after all 👍
| desc 'Build a WordPress Prototype Build and make it available for download' | ||
| desc 'Build a WordPress Prototype Build and upload it to Firebase App Distribution' | ||
| lane :build_and_upload_wordpress_prototype_build do | ||
| UI.user_error!("'BUILDKITE_ARTIFACTS_S3_BUCKET' must be defined as an environment variable.") unless ENV['BUILDKITE_ARTIFACTS_S3_BUCKET'] |
There was a problem hiding this comment.
Side note: at first I thought that now that we don't use that BUILDKITE_ARTIFACTS_S3_BUCKET anymore, that PR was missing a deletion of that constant / env var definition from wherever it was defined in this repo… but then I realized that this env var is not defined in this codebase/repo per se, but instead provided via ~/.mobile-secrets/CI/secrets/env. So there's no BUILDKITE_ARTIFACTS_S3_BUCKET definition to remove from this PR after all 👍
|
@nbradbury @jkmassel any concern with moving to Firebase App Distribution for WordPress and Jetpack Android Prototype Builds? If not, I'll merge this. Thanks for your input! |
|
I assume it's substantially similar to how it worked with App Center, so yep good to go! |
mokagio
deleted the
ainfra-1686-distribute-wordpress-and-jetpack-android-prototype-builds
branch
4 participants
Summary
Replace S3 upload with Firebase App Distribution (FAD) for WordPress and Jetpack prototype builds.
This aligns with other Android apps in the org (Day One, WooCommerce, Pocket Casts) and lets us delegate storage, distribution, and other management tasks to Firebase.
Ref: AINFRA-1686
Testing instructions
See test PR #22505 (as the files changed filter blocked this PR from generating the Firebase builds)
🤖 Generated with Claude Code, in particular, I fed it the previous PRs I worked on adding FAD for reference.