Fix option list filtering with autoload and transients#620
Open
ekamran wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes SQL WHERE clause operator-precedence issues in wp option list so that --autoload=on|off filtering does not inadvertently override transient inclusion/exclusion logic. It aligns the actual results with the command’s documented behavior: transients are excluded by default unless --transients is provided.
Changes:
- Grouped
autoloadconditions into a single parenthesizedAND ( ... OR ... )clause to avoidAND/ORprecedence bugs. - Grouped transient include/exclude conditions into a single parenthesized clause for consistent interaction with other filters.
- Added a Behat scenario covering
--autoload=onbehavior with transients (default exclusion vs--transientsinclusion).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Option_Command.php |
Fixes SQL condition grouping so --autoload and transient filters combine correctly. |
features/option-list.feature |
Adds/updates Behat coverage for transient exclusion by default when using --autoload=on. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
wp option list --autoload=oncould still include transient rows.The command already excludes transients by default unless
--transientsis used. This updates the SQL condition grouping so the autoload and transient filters are applied together correctly.Tests: