Skip to content

feat: Gas benchmark regression CI gate - #129

Merged
truthixify merged 5 commits into
wraith-protocol:developfrom
raizo07:feat/Gas-benchmark
Aug 6, 2026
Merged

feat: Gas benchmark regression CI gate#129
truthixify merged 5 commits into
wraith-protocol:developfrom
raizo07:feat/Gas-benchmark

Conversation

@raizo07

@raizo07 raizo07 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

closes #112

@drips-wave

drips-wave Bot commented Jul 24, 2026

Copy link
Copy Markdown

@raizo07 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@truthixify

Copy link
Copy Markdown
Contributor

The stellar and stellar-bench-pr checks failed against an older workspace state that has since been fixed on develop. Rebase and force-push and CI should look different.

@truthixify

Copy link
Copy Markdown
Contributor

Rebase against develop, conflicts appeared after the recent contracts merge cascade. Force-push and CI will re-fire.

@truthixify

Copy link
Copy Markdown
Contributor

Two specific failures:

  1. stellar fails on cargo fmt --all --check — run cargo fmt --all in stellar/ and commit.

  2. stellar-bench-pr fails with error: unknown argument: --bench from your gas benchmark binary. Cargo passes --bench to the binary automatically after your other args (that's what the trailing --bench in the log means). Two options:

    • Make the gas binary silently accept/ignore an unknown --bench flag, OR
    • Switch the workflow invocation from cargo bench to cargo run --release --bin gas -- --format json --out bench/results.json (which won't append --bench).

@raizo07
raizo07 force-pushed the feat/Gas-benchmark branch 2 times, most recently from 80b99db to 7e0a0b0 Compare August 3, 2026 13:39
@truthixify

truthixify commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Blocked by conflicts. Also, stellar-bench-pr is not writing stellar/bench/results.json. Please rebase, fix conflicts, and make the benchmark output that file.

raizo07 added 5 commits August 6, 2026 07:53
Ignore cargo injected --bench flag and require scheme_id=2 with non-empty metadata so the harness runs against current contracts.
Resolve --out against CARGO_MANIFEST_DIR, use a host-safe bench profile, enable contract testutils features, and refresh the baseline after the develop rebase.
@raizo07
raizo07 force-pushed the feat/Gas-benchmark branch from c3a1f8b to d6c98d6 Compare August 6, 2026 07:01
@raizo07

raizo07 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@truthixify kindly review

@truthixify
truthixify merged commit 044b9e3 into wraith-protocol:develop Aug 6, 2026
13 checks passed
@truthixify

Copy link
Copy Markdown
Contributor

Merged. Thanks @raizo07. The Stellar gas bench gate is green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gas benchmark regression CI gate

2 participants