Skip to content

chore: Remove unnecessary // @ts-ignore from auto-import output#2125

Closed
PatrykKuniczak wants to merge 1 commit intowxt-dev:mainfrom
PatrykKuniczak:chore/remove-ts-ignore-from-auto-imports
Closed

chore: Remove unnecessary // @ts-ignore from auto-import output#2125
PatrykKuniczak wants to merge 1 commit intowxt-dev:mainfrom
PatrykKuniczak:chore/remove-ts-ignore-from-auto-imports

Conversation

@PatrykKuniczak
Copy link
Copy Markdown
Collaborator

Overview

I've removed it, because it's unnecessary, there's no error, but maybe anybody knows, who to do it in more pretty way, that's not bad, but MEH.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 13, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2125

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2125

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2125

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2125

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2125

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2125

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2125

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2125

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2125

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2125

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2125

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2125

wxt

npm i https://pkg.pr.new/wxt@2125

commit: ec6dc1e

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 13, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit ec6dc1e
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/698f3663a3f30f0008c4a988
😎 Deploy Preview https://deploy-preview-2125--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.17%. Comparing base (2e2272d) to head (ec6dc1e).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
+ Coverage   76.14%   76.17%   +0.03%     
==========================================
  Files         113      113              
  Lines        3031     3035       +4     
  Branches      680      680              
==========================================
+ Hits         2308     2312       +4     
  Misses        639      639              
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrykKuniczak PatrykKuniczak enabled auto-merge (squash) February 13, 2026 15:11
Copy link
Copy Markdown
Member

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If unimport is exporting types with @ts-ignore, I'm gonna trust in the Nuxt team's decision to use them.

https://github.com/unjs/unimport/blob/e908b928f122e79b1f175eedc484be2f0c17e836/src/utils.ts#L247-L266

Not sure if the reason they provide is good or not for the latest version of typescript, but I'll let them decide when it's OK to remove them or not.

@aklinker1 aklinker1 closed this Feb 21, 2026
auto-merge was automatically disabled February 21, 2026 16:55

Pull request was closed

@PatrykKuniczak
Copy link
Copy Markdown
Collaborator Author

@aklinker1 No problem, we'll see: unjs/unimport#499 :)

@aklinker1
Copy link
Copy Markdown
Member

Perfect, thanks for creating that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants