chore: Remove unnecessary // @ts-ignore from auto-import output#2125
chore: Remove unnecessary // @ts-ignore from auto-import output#2125PatrykKuniczak wants to merge 1 commit intowxt-dev:mainfrom
// @ts-ignore from auto-import output#2125Conversation
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
==========================================
+ Coverage 76.14% 76.17% +0.03%
==========================================
Files 113 113
Lines 3031 3035 +4
Branches 680 680
==========================================
+ Hits 2308 2312 +4
Misses 639 639
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aklinker1
left a comment
There was a problem hiding this comment.
If unimport is exporting types with @ts-ignore, I'm gonna trust in the Nuxt team's decision to use them.
Not sure if the reason they provide is good or not for the latest version of typescript, but I'll let them decide when it's OK to remove them or not.
Pull request was closed
|
@aklinker1 No problem, we'll see: unjs/unimport#499 :) |
|
Perfect, thanks for creating that! |
Overview
I've removed it, because it's unnecessary, there's no error, but maybe anybody knows, who to do it in more pretty way, that's not bad, but MEH.