Convert all OpaqueRef fields in host, pool, SR and VM records#87
Merged
Conversation
xsconsole maps raw xapi OpaqueRef strings to typed HotOpaqueRef objects using hand-maintained converter tables in HotData. Newer XAPI releases added several Ref fields (e.g. host.control_domain, host.certificates, host.features, pool.repositories, VM.groups) that were missing from these tables. In testing mode this caused xsconsole to spam "Missed OpaqueRef" messages over the curses UI, notably on the Resource Pool Configuration screen. Add the missing Ref / Set(Ref) fields to the FetchHost, FetchPool, FetchSR and FetchVM converters, cross-referenced against the xen-api datamodel. Map(String, Ref) fields such as host.blobs are intentionally left unconverted. Signed-off-by: Stephen Cheng <stephen.cheng@citrix.com>
chunjiez
approved these changes
Jun 8, 2026
chunjiez
left a comment
chunjiez
left a comment
Collaborator
There was a problem hiding this comment.
I think it's possible to generate such a table by automatic method, however, it is not valuable. It's just a text UI application.
GeraldEV
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xsconsole maps raw xapi OpaqueRef strings to typed HotOpaqueRef objects using hand-maintained converter tables in HotData. Newer XAPI releases added several Ref fields (e.g. host.control_domain, host.certificates, host.features, pool.repositories, VM.groups) that were missing from these tables. In testing mode this caused xsconsole to spam "Missed OpaqueRef" messages over the curses UI, notably on the Resource Pool Configuration screen.
Add the missing Ref / Set(Ref) fields to the FetchHost, FetchPool, FetchSR and FetchVM converters, cross-referenced against the xen-api datamodel.