Test aspect Inf and all-NaN elevation input across backends (#3439)#3440
Merged
brendancol merged 1 commit intoJun 21, 2026
Conversation
…ontrib#3439) Add coverage for two untested Cat-2 inputs in test_aspect.py: - Inf / -Inf elevation cells: assert the planar output never contains Inf, and numpy/cupy/dask+numpy/dask+cupy agree. - All-NaN raster: aspect/northness/eastness return all-NaN with the shape preserved, on all four backends. Both behaviors are defined and consistent across backends today, so these pin the current contract. Test-only; no source change. Update sweep-test-coverage-state.csv aspect row. Closes xarray-contrib#3439.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3439.
Adds coverage for two Cat-2 inputs the aspect suite never exercised:
Both behaviors are defined and consistent across backends today, so these tests pin the current contract rather than fixing a bug. Test-only, no source change.
Validated locally on a CUDA host: all 16 new tests pass on all four backends, and the full test_aspect.py is green (225 passed).