Use element window instead of global object#5813
Open
CGNonofr wants to merge 1 commit intoxtermjs:masterfrom
Open
Use element window instead of global object#5813CGNonofr wants to merge 1 commit intoxtermjs:masterfrom
CGNonofr wants to merge 1 commit intoxtermjs:masterfrom
Conversation
CGNonofr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If xterm is running in another frame than its dom,
window.getComputedStylereturns an empty object in Firefox, which completely breaks the user selections