Skip to content

Conversation

@rossaddison
Copy link
Contributor

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌

Copy link
Contributor Author

@rossaddison rossaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared and viewed.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.21%. Comparing base (bc770fc) to head (3c0eadb).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
- Coverage     96.33%   96.21%   -0.12%     
+ Complexity      102      100       -2     
============================================
  Files            24       24              
  Lines           300      291       -9     
============================================
- Hits            289      280       -9     
  Misses           11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rossaddison
Copy link
Contributor Author

rossaddison commented Jan 21, 2026

php 8.1 to php 8.5 for mssql2017 is passing even though microsoft has not made any official release of a driver for php 8.5 since it takes them normally a year to release a driver. Adjusted workflow. (AI source: Github Copilot Auto). Included a few Readme's under docs which are advisory's only. The styling under the src/Reader/FilterHandler effected the code coverage which I have subsequently reverted.

@samdark
Copy link
Member

samdark commented Jan 25, 2026

Hello Ross. What are we supposed to do with this pull request?

The following style changes appear to have altered the code coverage so I am reverting them.
@rossaddison
Copy link
Contributor Author

  1. Microsoft's Copilot recommended adjusting the mssql.yml workflow specifically with an empty flag for 2017 and also with a 'less specific more general' tools/path. The toolspath recommendation for 2019 and 2022 is more specific however. Hence the possible reason why 2017 was failing in the workflow given the current settings.

  2. php8.5 support is already included in the pecl drivers and evidently is working as evidenced by the workflows above.

  3. actions/checkout@v6 upgraded from v3 to avoid security vulnerabilities.

  4. David Engels comment

@vjik
Copy link
Member

vjik commented Jan 27, 2026

Please split independent changes into separate PRs.

@rossaddison
Copy link
Contributor Author

Ok will do.

@rossaddison
Copy link
Contributor Author

I think that is all that needs to be adjusted for now. So generated two new pull requests which basically boil down to changing the workflow files mssql.yml and static.yml. I am closing this pull request. The phpcsfixer and styleci recommended changes and md files I have left out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants