-
-
Notifications
You must be signed in to change notification settings - Fork 3
Workflow Action Test 1 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rossaddison
commented
Jan 21, 2026
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ✔️/❌ |
| Breaks BC? | ✔️/❌ |
rossaddison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared and viewed.
Apply fixes from StyleCI
Actions/checkout v3 to v6: Potentially remove possible security vulnerabilities Avoid v3 deprecation in the future.
…into mssql2017
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
============================================
- Coverage 96.33% 96.21% -0.12%
+ Complexity 102 100 -2
============================================
Files 24 24
Lines 300 291 -9
============================================
- Hits 289 280 -9
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Apply fixes from StyleCI
Apply fixes from StyleCI
Include php 8.5 in mssql.yml
Apply fixes from StyleCI
Update Readme to cater for similar future mssql and php difficulties.
|
php 8.1 to php 8.5 for mssql2017 is passing even though microsoft has not made any official release of a driver for php 8.5 since it takes them normally a year to release a driver. Adjusted workflow. (AI source: Github Copilot Auto). Included a few Readme's under docs which are advisory's only. The styling under the src/Reader/FilterHandler effected the code coverage which I have subsequently reverted. |
|
Hello Ross. What are we supposed to do with this pull request? |
The following style changes appear to have altered the code coverage so I am reverting them.
|
|
Please split independent changes into separate PRs. |
|
Ok will do. |
|
I think that is all that needs to be adjusted for now. So generated two new pull requests which basically boil down to changing the workflow files mssql.yml and static.yml. I am closing this pull request. The phpcsfixer and styleci recommended changes and md files I have left out. |