Update mssql.yml #53
Open
Update mssql.yml #53
+21
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rossaddison
commented
Jan 27, 2026
rossaddison
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ✔️/❌ |
| Breaks BC? | ✔️/❌ |
Contributor
Author
|
Microsoft's Copilot recommended adjusting the mssql.yml workflow specifically with an empty flag for 2017 and also with a 'less specific more general' tools/path. The toolspath recommendation for 2019 and 2022 is more specific however. Hence the possible reason why 2017 was failing in the workflow given the current settings. |
vjik
requested changes
Jan 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
============================================
+ Coverage 96.33% 96.90% +0.57%
+ Complexity 102 100 -2
============================================
Files 24 24
Lines 300 291 -9
============================================
- Hits 289 282 -7
+ Misses 11 9 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Sergei Predvoditelev <[email protected]>
Co-authored-by: Sergei Predvoditelev <[email protected]>
vjik
reviewed
Jan 28, 2026
Member
|
@rossaddison see logs: |
First sed: Changes HTTP to HTTPS in the repository URL (more secure and sometimes required) Second sed: Adds the [signed-by=/usr/share/keyrings/microsoft-prod.gpg] directive to tell apt which keyring to use for verifying packages This ensures apt can properly verify the Microsoft repository packages using the keyring you stored in the first curl command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.