-
-
Notifications
You must be signed in to change notification settings - Fork 17
Remove deprecated ThrowableResponseFactory
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vjik
commented
Jan 9, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Fix #146 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
============================================
- Coverage 80.83% 78.99% -1.84%
+ Complexity 216 197 -19
============================================
Files 20 19 -1
Lines 668 619 -49
============================================
- Hits 540 489 -51
- Misses 128 130 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the deprecated Yiisoft\ErrorHandler\Factory\ThrowableResponseFactory class as part of a breaking change for version 5.0.0. The deprecated factory class is replaced with the newer Yiisoft\ErrorHandler\ThrowableResponseFactory that uses a renderer provider pattern for better extensibility.
Key changes:
- Removes deprecated factory class and its test file
- Updates dependency injection configuration to use the new factory with composite renderer providers
- Adds upgrade instructions and changelog entry for version 5.0.0
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Factory/ThrowableResponseFactory.php | Removes the deprecated factory class that was marked for removal |
| tests/Factory/ThrowableResponseFactoryTest.php | Removes test coverage for the deprecated factory class |
| config/di-web.php | Updates DI configuration to instantiate the new ThrowableResponseFactory with CompositeRendererProvider combining HeadRendererProvider and ContentTypeRendererProvider |
| UPGRADE.md | Adds upgrade instructions documenting the breaking change from 4.x to 5.0.0 |
| CHANGELOG.md | Documents the removal in version 5.0.0 changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## 5.0.0 under development | ||
|
|
||
| - no changes in this release. | ||
| - Chg #162: Replace deprecated `ThrowableResponseFactory` class usage to new one, and remove it (@vjik) |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CHANGELOG references issue #162, but the PR description states "Fix #146". These issue numbers should be consistent. Please verify which issue number is correct and update accordingly.
| - Chg #162: Replace deprecated `ThrowableResponseFactory` class usage to new one, and remove it (@vjik) | |
| - Chg #146: Replace deprecated `ThrowableResponseFactory` class usage to new one, and remove it (@vjik) |
Co-authored-by: Alexander Makarov <[email protected]>