Skip to content

YPE-1292: Fix BibleReader.Toolbar grid layout breaks when auth disabled #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameronapak merged 2 commits into from
Feb 23, 2026
Merged

YPE-1292: Fix BibleReader.Toolbar grid layout breaks when auth disabled #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5cd76a
fix(ui): conditionally set toolbar grid cols based on auth state
cameronapak Feb 23, 2026
49ac153
Added changeset
cameronapak Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/warm-icons-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@youversion/platform-react-ui': patch
'@youversion/platform-core': patch
'@youversion/platform-react-hooks': patch
---

Fixed a styling bug on the BibleReader.Toolbar component. When auth was disabled in the YouVersionProvider, then it caused a layout issue on the toolbar.
7 changes: 6 additions & 1 deletion packages/ui/src/components/bible-reader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,12 @@ function Toolbar({ border = 'top' }: { border?: 'top' | 'bottom' }) {
border === 'bottom' && 'yv:border-b',
)}
>
<div className="yv:grid yv:w-full yv:grid-cols-[auto_1fr_auto] yv:items-center yv:max-w-lg yv:gap-4">
<div
className={cn(
'yv:grid yv:w-full yv:items-center yv:max-w-lg yv:gap-4',
yvContext?.authEnabled ? 'yv:grid-cols-[auto_1fr_auto]' : 'yv:grid-cols-[1fr_auto]',
)}
>
{!!yvContext?.authEnabled && <UserMenu />}

<div className="yv:grid yv:grid-cols-2 yv:gap-0.5">
Expand Down