-
Notifications
You must be signed in to change notification settings - Fork 796
Add duration template for all function using std::chrono::milliseconds #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 20377959475Details
💛 - Coveralls |
d2be5ed to
79b3bd2
Compare
|
Not sure how to unit test this properly.. Is there a "check if compiles" kind of unit tests for catch2? |
|
To check if something compiles or not you could use C++20/23 and concept or requires expressions. |
…ce the template would be a breaking change in C++17 and bellow
01aa0b9 to
df53698
Compare
|
Fixed CI by rebasing on master |
|
My only worry is that -1 (ms) has special meaning of no timeout, so passing e.g. seconds{-1} would be converted to -1000 ms, and it is unspecified in libzmq what will happen in that case. |
|
I removed the template in the poll function in df53698 Is there another place where this -1 is an issue? |
Makes the bindings slightly easier to use when dealing with durations. With the bindings handling the cast instead of the user