Merged
Conversation
Contributor
Author
|
Not sure why the CI is failing |
gummif
reviewed
Dec 10, 2025
gummif
reviewed
Dec 10, 2025
gummif
reviewed
Dec 10, 2025
gummif
reviewed
Dec 10, 2025
Member
|
Could you try bumping the C++ version of the gcc-9 test to gcc-11? |
Contributor
Author
|
I think I addressed all of your comments, the CI is still failing tho 🤔 |
Member
|
Ok looks good. Just need to figure out this CI issue. |
Contributor
Author
|
Other PRs have failing CI aswell, probably some dependency wasn't fixed |
Contributor
Author
|
Need to build libzmq with |
Contributor
Author
|
Only failure left is the coverage where it seems there is different versions for my test file: |
Contributor
Author
|
Okay, let me know if you're happy with the end state of the CI (I changed to gcc11, removed some warnings when building libzmq and added a job for the curve feature) |
c91d676 to
5b1cf57
Compare
Pull Request Test Coverage Report for Build 20334274751Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 20335143482Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #670