Conversation
|
What do you mean that it's related? Should it be reviewed after the other one is merged? Or should the changes here be pushed to the PR you already have open? |
What i mean is the current PR passes 13/14 checks, the 1 check which is failing is not due to the code, its some unrelated issue so i am waiting for the review. sorry for any confusion. |
|
This PR makes over a million lines of changes, so I'll go ahead and close it out. Please review the contributor guide to learn how to contribute to Zulip, and avoid wasting maintainer time. |
This is PR related to issue #649 wherein I changed the occurence of !avatar syntax from /zulip/integration/git.
Fixes: I changed the occurence of this syntax from 2 files :
How did you test this PR?
After successfully removing the !avatar syntax from these locations i ran a commit message locally with dummy entries and found that everything is working fine.
Self-review checklist
(variable names, code reuse, readability, etc.).
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: