Skip to content

Conversation

@gfelbing
Copy link

Many projects offer a single asset in form of a sha256sum file, e.g. k9s. This PR checks the asset list for such files and verifies a checksum against it.

@zyedidia
Copy link
Owner

How is this different than the existing functionality that verifies checksums?

@gfelbing
Copy link
Author

gfelbing commented Oct 21, 2023

The current functionality only uses single-file checksums, e.g. when there is a binaryname.sha256 next to binaryname.
Many projects offer their checksums in a single sha256 file format, e.g. the checksums.txt in k9s.
This PR adds the functionality for checking against such files.

@hhromic
Copy link
Contributor

hhromic commented Oct 29, 2023

+1 for this feature.

GoReleaser is used by many Go projects nowadays and it generates single checksum files by default as well.
Their own releases page is an example.

Many projects offer a single asset in form of a sha256sum file, e.g. [k9s](https://github.com/derailed/k9s/releases).
This PR checks the asset list for such files and verifies a checksum against it.
@gfelbing gfelbing force-pushed the feature/sha256sum_files branch from 87d8589 to ed06b85 Compare February 27, 2024 21:01
@gfelbing
Copy link
Author

@zyedidia I rebased the PR against your latest master and simplified the match for sha256files.
Is there anything you are missing from the PR?
If you need more examples for the usefulness of the feature: e.g. kubebuilder uses a single checksums file as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants