Relax lifetimes returned by methods of Utf8StringRef#375
Open
DCNick3 wants to merge 1 commit into3Hren:masterfrom
Open
Relax lifetimes returned by methods of Utf8StringRef#375DCNick3 wants to merge 1 commit into3Hren:masterfrom
Utf8StringRef#375DCNick3 wants to merge 1 commit into3Hren:masterfrom
Conversation
Previously, `Utf8StringRef::as_bytes` and some other methods returned references with lifetime bound to `&self`, while the actual reference lifetime is `'a`.
With this change, a function life this could now be written:
```
fn extract_bytes<'a>(value: rmpv::ValueRef<'a>) -> &'a [u8] {
match auth_request {
rmpv::ValueRef::String(s) => s.as_bytes(),
rmpv::ValueRef::Binary(s) => s,
_ => panic!(),
}
}
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Utf8StringRef::as_bytesand some other methods returned references with lifetime bound to&self, while the actual reference lifetime is'a.With this change, a function life this could now be written: