Skip to content

Relax lifetimes returned by methods of Utf8StringRef #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DCNick3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Relax lifetimes returned by methods of Utf8StringRef #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rmpv/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ impl<'a> Utf8StringRef<'a> {
/// Returns the string reference if the string is valid UTF-8, or else `None`.
#[inline]
#[must_use]
pub fn as_str(&self) -> Option<&str> {
pub fn as_str(&self) -> Option<&'a str> {
self.s.ok()
}

Expand All @@ -372,7 +372,7 @@ impl<'a> Utf8StringRef<'a> {
/// Returns a byte slice of this string contents no matter whether it's valid or not UTF-8.
#[inline]
#[must_use]
pub const fn as_bytes(&self) -> &[u8] {
pub const fn as_bytes(&self) -> &'a [u8] {
match self.s {
Ok(s) => s.as_bytes(),
Err(ref err) => err.0,
Expand Down