refine foundry tools support for agent framework #44652
Conversation
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @melionel! We will review the pull request and get back to you soon. |
| tools = await self._foundry_tool_client.list_tools() | ||
| base = context.chat_options or ChatOptions() | ||
| base_tools = base.tools or [] | ||
| context.chat_options.tools = base_tools + tools |
| :ivar Any value: The result value from the tool invocation. | ||
| """ | ||
| value: Any = Field(serialization_alias="toolResult") | ||
| value: Any = Field(validation_alias="toolResult", serialization_alias="toolResult") |
There was a problem hiding this comment.
we can remove serialization_alias="toolResult" since we only do deserialize
There was a problem hiding this comment.
removing this will case the connected tool invocation result validation failure:
| ], | ||
| Discriminator( | ||
| lambda payload: "ErrorType" if isinstance(payload, dict) and "type" in payload else "ResultType" | ||
| lambda payload: "ErrorType" if isinstance(payload, dict) and |
There was a problem hiding this comment.
in service code, only error related response has field 'type'
There was a problem hiding this comment.
that's not true. even the success response contains the 'type' field
| payload_text = response.text() | ||
| payload_json = json.loads(payload_text) if payload_text else {} | ||
| except AttributeError as e: | ||
| payload_bytes = response.body() |
There was a problem hiding this comment.
what scenario will trigger this exception?
There was a problem hiding this comment.
just in case the response has no text()
| async with response: | ||
| invoke_response = InvokeFoundryConnectedToolsResponse.model_validate(response.json()) | ||
| try: | ||
| payload_text = response.text() |
There was a problem hiding this comment.
seems we can move them to base operations if we need do the same thing on every response
2 participants
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines