publish: inline gather/extract bash, simplify gather with priority-overwrite model#35
Merged
Conversation
…erwrite model Replaces assemble/assemble.sh with inline bash steps in publish.yml's deploy job and restructures the gather phase around a "maximally gather, overwriting with higher priority" model (releases → branch CI → current build). Key changes: - Delete assemble/assemble.sh; all gh/unzip/mv IO lives as named steps in publish.yml - Seed release stored as $DEFAULT.zip (not skipped) so the overwrite chain supersedes it - Combine default-branch and PR gather into one step with a shared gather_run() helper that does the API lookup + download in one call, using the workflow filename (ci.yml) consistently via the /actions/workflows/ci.yml/runs endpoint - Download this run's docs artifact and Stage current build are now adjacent, share the same if: guard, and the current build wins by being placed last in the gather dir - Remove guard-default-branch input: missing DEFAULT now always hard-fails (at the new Ensure default-branch zip step) rather than being suppressible - assemble.mjs and docs updated to reflect the new gather model Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
runner context is not available during expression parsing of a called reusable
workflow's job-level env block. Replace SITE=${{ runner.temp }}/site with
$RUNNER_TEMP/site (runner env var, always set) in shell steps, and
${{ runner.temp }}/site in step with:/env blocks where runner is valid.
Drops the now-unnecessary id: site step output.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assemble/assemble.sh; allgh/unzip/mvIO is now named inline steps inpublish.yml'sdeployjob$ARTIFACT_VERSION_NAMEexclusion guards needed$DEFAULT.zip(handled in the release gather step) rather than a bespoke third fallback runggather_run()helper; both use the/actions/workflows/ci.yml/runsendpoint consistently (workflow filename, not display name)Download this run's docs artifactandStage current buildare now adjacent and share the sameif: inputs.version-name != ''guardguard-default-branchinput — missing DEFAULT now always hard-fails at theEnsure default-branch zipsteparchitecture.md,reference/workflows.md,CLAUDE.md,CONTRIBUTING.md) updated throughoutTest plan
npm testpasses (pure logic inassemble.mjsunchanged)_sources/main.zipstill persisted in siteguard-default-branchremoved — confirm consumers passing it get a harmless unknown-input warning, not a failure🤖 Generated with Claude Code