chore(#3769): Migrate design system guidelines from the MCP into docs site#3771
chore(#3769): Migrate design system guidelines from the MCP into docs site#3771
Conversation
Spark450
left a comment
Spark450
left a comment
There was a problem hiding this comment.
Just a few comments and suggestions.
| tags: | ||
| - user-types | ||
| - citizen | ||
| - worker |
There was a problem hiding this comment.
I know when I was reviewing the "workspace" docs I pushed to have this term changed to "service delivery worker". Should we align the language in this document as well?
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| id: linkbutton-vs-link | |||
There was a problem hiding this comment.
Should we remove this one, since we are going to undocument the link-button?
| --- | ||
| id: pagination-links-only-mobile | ||
| type: tip | ||
| description: Use variant='links-only' for a simpler mobile-friendly pagination with just previous and next links. |
There was a problem hiding this comment.
I think right now we have buttons instead of links in the pagination control, should we change the description to say "...previous and next buttons"
| --- | ||
| id: picking-a-date-component | ||
| type: tip | ||
| description: "DatePicker handles most date inputs. Use type='input' (a dropdown for month and text inputs for day and year) for known dates like birthdays, far in the past or far in the future. Use type='calendar' (a popup calendar) for dates closer to real time when the user is picking from available days, like booking or scheduling." |
There was a problem hiding this comment.
should "for dates closer to real time" instead be: "for dates closer to the current day"
twjeffery
force-pushed
the
tom/foundations-collection
branch
from
df381b7 to
a3d6ee5
Compare
✅ Deploy Preview for benji-docs-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I addressed all your comments @Spark450, good for another review |
2 participants
Closes #3769
The MCP repo has design system guidelines that should be in the docs site. This PR migrates them into the docs site content collections so the per-component ones start showing up on component pages as do's and don'ts right away, and we have a single source of truth to maintain.
What's in this PR
foundations/content collection (schema inconfig.ts, documented inARCHITECTURE.md) for higher-level guidelinesradio-groupinstead ofradioNotes