Package name change from amRshiny to amRviz + New Visualizations#20
Open
eboyer221 wants to merge 7 commits into
Open
Package name change from amRshiny to amRviz + New Visualizations#20eboyer221 wants to merge 7 commits into
eboyer221 wants to merge 7 commits into
Conversation
This was referenced May 14, 2026
Contributor
|
@eboyer221 I reviewed it. I got the model performance to default to "all", removed ComplexHeatmap dependencies since everything is plotly now, removed some dead code and observers, and it should be passing R CMD CHECK again because I added param for amrdata_root. Everything looked good. I'll approve merging when the repo name is changed by an admin @jananiravi @epbrenner @AbhirupaGhosh Please change the name of the repo as Emily specified above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the package from
amRshinytoamRviz(inDESCRIPTION, code, tests, docs, and the.Rprojfile). However, the GitHub repository itself is still namedamRshinyand needs to be renamed manually by someone with admin access (I, eboyer221, do not have admin privileges to rename the repo):amRshiny→amRvizSummary
Renames the package from
amRshinytoamRvizand adds several new visualizations and dashboard fixes.Package rename
amRshiny→amRviz(DESCRIPTION, allsystem.file()calls, tests, README, vignettes, docs)amRshiny.Rproj→amRviz.RprojNew visualizations
Annotations
cluster(with BVBRC link) andCOG(with NCBI COG link) columns whencluster_feature_COG.parquetis available.gene_names.parquet,protein_names.parquet, ordomain_names.parquet(located inamrdata_root/<species>/).Dashboard fixes
New parameter
launchAMRDashboard(results_root, amrdata_root):amrdata_rootdefaults to~/amRdata/dataif present and is used to locate annotation parquets for name lookup.Demo data
inst/extdata/Shigella_flexneri/cluster_feature_COG.parquetso annotation-based visualizations work.Test plan
To approve - verify each tab renders without errors: